Repository navigation
build(deps): SkiaSharp 4.156.1, Uno 7 and PublicApiAnalyzers 5.6 - #300
Open
michaelstonis wants to merge 4 commits into
Open
michaelstonis wants to merge 4 commits into
michaelstonis wants to merge 4 commits into
Conversation
…zSharp native assets to 14.4.0.101 SkiaSharp 4.156.1 moves several dependency floors, so these bumps have to land together: - SkiaSharp.Views.Maui.Controls requires Microsoft.Maui.Controls 10.0.110, so the explicit 10.0.20 floor in KumikoUI.Maui was an NU1605 downgrade. MauiVersion is now 10.0.110. - SkiaSharp.Views.Uno.WinUI requires Uno.WinUI 7.0.0-dev.2333 or later, which Uno.Sdk 6.7 cannot provide (NU1605). Uno.Sdk moves to 7.0.22 and UnoWinUIVersion (the TypeNameCheck baseline) to 7.0.65, the Uno.WinUI version that SDK resolves. - SkiaSharp.HarfBuzz depends on HarfBuzzSharp 14.4.0.101, so the Linux and WebAssembly native assets, which must match the managed version, move to 14.4.0.101. Uno 7 changes: - The SkiaRenderer feature is ignored in a library (UNOB0030). The library uses the Skia feature, which resolves SKCanvasElement. - That feature no longer brings in SkiaSharp.Views.Uno.WinUI (SKXamlCanvas), so KumikoUI.Uno references it explicitly on every non-Windows head. The README version references move to 4.156.1.
Version 5.x reports the members the compiler synthesizes for records, record structs and delegates (Equals, GetHashCode, ToString, ==, !=, Deconstruct, <Clone>$, the delegate Invoke) as public API under RS0016. They were always part of the public surface; the old analyzer did not require them to be declared. Regenerated KumikoUI.Core's PublicAPI.Unshipped.txt with eng/update-public-api.sh. KumikoUI.SkiaSharp, KumikoUI.Maui and KumikoUI.Uno have no changes.
- Android: NativeApplication and ApplicationActivity moved to Uno.UI.Runtime.Android, and the application class now builds the host in CreateHost(). - Reference HarfBuzzSharp's native libraries at 14.4.0.101 on each head. Uno.Sdk 7.0.22 adds them at 14.4.0.100, but the managed HarfBuzzSharp that Uno.WinUI and SkiaSharp.HarfBuzz depend on is 14.4.0.101 and requires matching natives (NU1605 downgrade otherwise). Also update the pinned-toolchain table, the roadmap and the changelog for Uno.Sdk 7 and SkiaSharp 4.156.1.
…e package Uno.Sdk 7's Skia feature adds Uno.WinUI.Composition.Skia, which the nuspec handed on as a dependency, and it adds its uno-proguard.cfg to every Android project, so the library packed a KumikoUI.Uno.aar. Mark the package private like Graphics2DSK and drop the ProGuard item from the library; app heads get both from their own Uno.Sdk.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #282 and #284, which fail CI.
This moves KumikoUI.Uno to Uno 7, a breaking change for Uno consumers; it needs a maintainer decision before merging.
Why the Dependabot PRs fail
SkiaSharp.Views.Maui.ControlsneedsMicrosoft.Maui.Controls10.0.110 (NU1605 against 10.0.20),SkiaSharp.Views.Uno.WinUIneedsUno.WinUI7 (the Uno jobs were skipped on the PR, so CI never showed it), andSkiaSharp.HarfBuzzneeds HarfBuzzSharp 14.4.0.101.Changes
MauiVersion10.0.110, Uno.Sdk 7.0.22 (TypeNameCheck baseline Uno.WinUI 7.0.65), HarfBuzzSharp native assets 14.4.0.101.KumikoUI.Uno.csproj: theSkiaRendererfeature is ignored in a library under Uno 7 (UNOB0030), so it usesSkiaand referencesSkiaSharp.Views.Uno.WinUIexplicitly on non-Windows heads.PublicAPI.Unshipped.txtregenerated (36 lines, no suppressions).NativeApplication/ApplicationActivitynamespaces,CreateHost()), with explicit HarfBuzzSharp native references because Uno.Sdk 7.0.22 pins 14.4.0.100.Verified locally (macOS arm64)
Core 3136, SkiaSharp 41, SourceGenerators 9, MAUI 336 and Uno 281 tests pass; golden images unchanged. MAUI and Uno libraries and both samples build on every Apple, Android, WebAssembly and desktop head; doc snippets build; Core and SkiaSharp tests pass in Linux arm64 Docker.
Not run: Windows heads, Native AOT jobs, the trimmed WebAssembly publish. The Uno device checks in
docs/uno/verification.mdwere all made on Uno 6.7.